Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove incorrect lettuce-4.0 db.statement attribute #4160

Merged
merged 1 commit into from
Sep 22, 2021
Merged

Remove incorrect lettuce-4.0 db.statement attribute #4160

merged 1 commit into from
Sep 22, 2021

Conversation

trask
Copy link
Member

@trask trask commented Sep 17, 2021

following #4152, and removing db.statement since it's not really capturing db.statement

(note: lettuce-5.0 and lettuce-5.1 do capture db.statement correctly, I looked and it wasn't straight forward to port that back to lettuce-4.0)

@trask
Copy link
Member Author

trask commented Sep 17, 2021 •
edited
Loading

Hm, but db.statement is marked required, so maybe existing behavior is better?

Required if applicable and not explicitly disabled via instrumentation configuration.

https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/database.md#call-level-attributes

@trask
Copy link
Member Author

trask commented Sep 18, 2021

/easycla

mateuszrzeszutek
mateuszrzeszutek approved these changes Sep 20, 2021
View reviewed changes
Copy link
Member

@mateuszrzeszutek mateuszrzeszutek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case of lettuce 4.0 we really can't extract the statement, the library doesn't allow doing that. I think it's probably better not to set the statement if we can't get the real value.

@trask
Copy link
Member Author

trask commented Sep 22, 2021

I think it's probably better not to set the statement if we can't get the real value.

👍

also, I just noticed this part of the spec that I missed previously:

db.operation | Required, if db.statement is not applicable.

@trask trask merged commit f24dd61 into open-telemetry:main Sep 22, 2021
@trask trask deleted the remove-lettuce-db-statement-attr branch September 22, 2021 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

@anuraaga anuraaga Awaiting requested review from anuraaga

@iNikem iNikem Awaiting requested review from iNikem

@jkwatson jkwatson Awaiting requested review from jkwatson

@laurit laurit Awaiting requested review from laurit

@pavolloffay pavolloffay Awaiting requested review from pavolloffay

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trask @mateuszrzeszutek